Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate to a single tools/ow-utils docker image #4158

Merged
merged 1 commit into from
Dec 6, 2018

Conversation

dgrove-oss
Copy link
Member

Rather than defining separate images for running shell scripts,
running ansible playbooks, running gradle tasks, etc. switch
to an uber utility image that will include wsk, wsk-deploy,
and all the software packages to execute our various scripting
languages.

Note that this image cannot be alpine based because of the DNS
race condition bug (see #4052).
Overall image size is 884MB, which is bigger than one would like but probably
tolerable.

@codecov-io
Copy link

codecov-io commented Dec 5, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@ec36051). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4158   +/-   ##
=========================================
  Coverage          ?   79.77%           
=========================================
  Files             ?      151           
  Lines             ?     7279           
  Branches          ?      464           
=========================================
  Hits              ?     5807           
  Misses            ?     1472           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec36051...e410780. Read the comment docs.

Rather than defining separate images for running shell scripts,
running ansible playbooks, running gradle tasks, etc. switch
to an uber utility image that will include wsk, wsk-deploy,
and all the software packages to execute our various scripting
languages.
@dgrove-oss
Copy link
Member Author

With some advice from @jonpspri cut the image down to 607MB (changes squashed & force-pushed)

@jonpspri
Copy link
Contributor

jonpspri commented Dec 6, 2018

I don't think --no-install-recommends made it into the current commit. I may also have a PR in a little bit to make the wsk and wskdeploy more multi-arch friendly.

Copy link
Member

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgrove-oss
Copy link
Member Author

I built images both with and without --no-install-recommends and it didn't change the image size.

@csantanapr csantanapr merged commit 570c044 into apache:master Dec 6, 2018
@dgrove-oss dgrove-oss deleted the utilityImage branch December 6, 2018 15:12
@rabbah rabbah added the tooling label Feb 9, 2019
BillZong pushed a commit to BillZong/openwhisk that referenced this pull request Nov 18, 2019
Rather than defining separate images for running shell scripts,
running ansible playbooks, running gradle tasks, etc. switch
to an uber utility image that will include wsk, wsk-deploy,
and all the software packages to execute our various scripting
languages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants