-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate to a single tools/ow-utils docker image #4158
Conversation
744d06b
to
35a6740
Compare
Codecov Report
@@ Coverage Diff @@
## master #4158 +/- ##
=========================================
Coverage ? 79.77%
=========================================
Files ? 151
Lines ? 7279
Branches ? 464
=========================================
Hits ? 5807
Misses ? 1472
Partials ? 0 Continue to review full report at Codecov.
|
35a6740
to
a083939
Compare
Rather than defining separate images for running shell scripts, running ansible playbooks, running gradle tasks, etc. switch to an uber utility image that will include wsk, wsk-deploy, and all the software packages to execute our various scripting languages.
a083939
to
e410780
Compare
With some advice from @jonpspri cut the image down to 607MB (changes squashed & force-pushed) |
I don't think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing updates to jenkins file
https://github.com/apache/incubator-openwhisk/blob/master/tools/jenkins/apache/dockerhub.groovy#L32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I built images both with and without |
Rather than defining separate images for running shell scripts, running ansible playbooks, running gradle tasks, etc. switch to an uber utility image that will include wsk, wsk-deploy, and all the software packages to execute our various scripting languages.
Rather than defining separate images for running shell scripts,
running ansible playbooks, running gradle tasks, etc. switch
to an uber utility image that will include wsk, wsk-deploy,
and all the software packages to execute our various scripting
languages.
Note that this image cannot be alpine based because of the DNS
race condition bug (see #4052).
Overall image size is 884MB, which is bigger than one would like but probably
tolerable.